netdev - Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140425174322.589ed9f1@samsung-9>
Date:	Fri, 25 Apr 2014 17:43:22 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, jasowang@...hat.com,
	stable@...nel.org
Subject: Re: [PATCH net-next 1/1]  hyperv: Properly handle checksum offload

On Fri, 25 Apr 2014 11:45:14 -0700
"K. Y. Srinivasan" <kys@...rosoft.com> wrote:

> @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
>  	csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi +
>  			ppi->ppi_offset);
>  
> +	ip_hdr(skb)->check = 0;
> +	csum_info->transmit.ip_header_checksum = 1;
> +
>  	if (net_trans_info & (INFO_IPV4 << 16))
>  		csum_info->transmit.is_ipv4 = 1;
>  	else

Linux doesn't need or want IP checksum offload.
It will not have any performance gain.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html