netdev - Re: [PATCH] tools: bpf_dbg: register misuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <535E1604.2090404@redhat.com>
Date:	Mon, 28 Apr 2014 10:49:08 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Brendan Hickey <bhickey@...gle.com>
CC:	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] tools: bpf_dbg: register misuse

On 04/25/2014 11:23 PM, Brendan Hickey wrote:
> From: Brendan Hickey <bhickey@...gle.com>
> Date: Fri, 25 Apr 2014 17:22:52 -0400
> Subject: [PATCH] bpf_dbg: Fix erroneous register use for AND
>
> The AND instruction is erroneously using the X register instead of the K
> register.
>
> Signed-off-by: Brendan Hickey <bhickey@...gle.com>

Sorry for the late reply as I'm on vacations currently.

Patch looks good to me, but it looks like it got whitespace
corrupted by your email client. Please submit this against
'net' in subject line. Otherwise when this is fixed, feel
free to add my ack:

Acked-by: Daniel Borkmann <dborkman@...hat.com>

Thanks, Brendan!

> ---
>   tools/net/bpf_dbg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c
> index 65dc757..5e54848 100644
> --- a/tools/net/bpf_dbg.c
> +++ b/tools/net/bpf_dbg.c
> @@ -823,7 +823,7 @@ do_div:
>                  r->A &= r->X;
>                  break;
>          case BPF_ALU_AND | BPF_K:
> -               r->A &= r->X;
> +               r->A &= K;
>                  break;
>          case BPF_ALU_OR | BPF_X:
>                  r->A |= r->X;
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html