netdev - RE: [PATCH 1/1] iproute2: v3: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <290BEC245535C3449143D5D84900EEF78CE1CC79@avmb3.qlogic.org>
Date:	Mon, 28 Apr 2014 09:10:13 +0000
From:	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	netdev <netdev@...r.kernel.org>,
	Dept-HSG Linux NIC Dev <Dept-HSGLinuxNICDev@...gic.com>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>,
	"gregory.v.rose@...el.com" <gregory.v.rose@...el.com>,
	"linux-net-drivers@...arflare.com" <linux-net-drivers@...arflare.com>,
	"Ariel Elior" <Ariel.Elior@...gic.com>,
	"amirv@...lanox.com" <amirv@...lanox.com>,
	"mkubecek@...e.cz" <mkubecek@...e.cz>
Subject: RE: [PATCH 1/1] iproute2: v3: Add support to configure SR-IOV VF
 minimum and maximum Tx rate through ip tool.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> Sent: Wednesday, April 23, 2014 4:11 AM
> To: Sucheta Chakraborty
> Cc: netdev; Dept-HSG Linux NIC Dev; ben@...adent.org.uk;
> gregory.v.rose@...el.com; linux-net-drivers@...arflare.com; Ariel
> Elior; amirv@...lanox.com; mkubecek@...e.cz
> Subject: Re: [PATCH 1/1] iproute2: v3: Add support to configure SR-IOV
> VF minimum and maximum Tx rate through ip tool.
> 
> On Mon, 14 Apr 2014 00:37:00 -0400
> Sucheta Chakraborty <sucheta.chakraborty@...gic.com> wrote:
> 
> > o "min_tx_rate" option has been added for minimum Tx rate. Hence, for
> >   consistent naming, "max_tx_rate" option has been introduced for
> maximum
> >   Tx rate.
> >
> > o Change in v2: "rate" can be used along with "max_tx_rate".
> >   When both are specified, "max_tx_rate" should override.
> >
> > o Change in v3:
> >   * IFLA_VF_RATE: When IFLA_VF_RATE is used, and user has given only
> one of
> >     min_tx_rate or max_tx_rate, reading of previous rate limits is
> done in
> >     userspace instead of in kernel space before ndo_set_vf_rate.
> >
> >   * IFLA_VF_TX_RATE: When IFLA_VF_TX_RATE is used, min_tx_rate is
> always read
> >     in kernel space. This takes care of below scenarios:
> >     (1) when old tool sends "rate" but kernel is new (expects min and
> max)
> >     (2) when new tool sends only "rate" but kernel is old (expects
> > only "rate")
> >
> > Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
> 
> I like the concept fine, but the general policy of ip route commands is
> that the output format should match the input (except for statistics).
> 
> This (and ther earlier tx_rate patch are printing values in a different
> format than the input
> 
> i.e don't print:
> 	max tx rate 110 (Mbps)
> instead print:
> 	max_tx_rate 110Mbps
> 
> 
With this change display would be as below:

vf 0 MAC 3e:a0:ca:bd:ae:5a, tx rate 300 (Mbps), max_tx_rate 300Mbps,
    min_tx_rate 200Mbps

I did not change tx rate option to maintain backward compatibility.

Is the output valid?

Thanks,
Sucheta.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html