lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Apr 2014 08:57:20 -0500 From: Frank Li <lznuaa@...il.com> To: David Laight <David.Laight@...lab.com> Cc: Frank Li <Frank.Li@...escale.com>, "shawn.guo@...aro.org" <shawn.guo@...aro.org>, "B38611@...escale.com" <B38611@...escale.com>, "davem@...emloft.net" <davem@...emloft.net>, "rmk+kernel@....linux.org.uk" <rmk+kernel@....linux.org.uk>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 5/7] net:fec: add support for dumping transmit ring on timeout On Tue, Apr 29, 2014 at 8:38 AM, David Laight <David.Laight@...lab.com> wrote: > From: Of Frank Li > ... >> When we timeout on transmit, it would be useful to dump the transmit >> ring, so we can see the ring state. This can be helpful to diagnose >> the cause of transmit timeouts. > ... >> +static void fec_dump(struct net_device *ndev) >> +{ >> + struct fec_enet_private *fep = netdev_priv(ndev); >> + struct bufdesc *bdp = fep->tx_bd_base; >> + unsigned index = 0; >> + >> + netdev_info(ndev, "TX ring dump\n"); >> + pr_info("Nr SC addr len SKB\n"); >> + >> + do { >> + pr_info("%3u %c%c 0x%04x 0x%08lx %4u %p\n", >> + index, >> + bdp == fep->cur_tx ? 'S' : ' ', >> + bdp == fep->dirty_tx ? 'H' : ' ', >> + bdp->cbd_sc, bdp->cbd_bufaddr, bdp->cbd_datlen, >> + fep->tx_skbuff[index]); >> + bdp = fec_enet_get_nextdesc(bdp, fep); >> + index++; >> + } while (bdp != fep->tx_bd_base); >> +} >> + > > You probably want the read and write indexes as well. bdp == fep->cur_tx ? 'S' : ' ', bdp == fep->dirty_tx ? 'H' : ' ', Above code already print read and write index. 'S', 'H' Frank Li > > David > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists