netdev - Re: [PATCH net] tcp: increment retransmit counters in tlp and fast open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2014 09:44:54 -0400
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Nandita Dukkipati <nanditad@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net] tcp: increment retransmit counters in tlp and fast open

On Tue, Apr 29, 2014 at 1:00 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> Both TLP and Fast Open call __tcp_retransmit_skb() instead of
> tcp_retransmit_skb() to avoid changing tp->retrans_out.
>
> This has the side effect of missing SNMP counters increments as well
> as tcp_info tcpi_total_retrans updates.
>
> Fix this by moving the stats increments of into __tcp_retransmit_skb()
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html