netdev - Re: [PATCH net] tcp: increment retransmit counters in tlp and fast open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140430.161511.665163855966614835.davem@davemloft.net>
Date:	Wed, 30 Apr 2014 16:15:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, nanditad@...gle.com, ycheng@...gle.com,
	ncardwell@...gle.com
Subject: Re: [PATCH net] tcp: increment retransmit counters in tlp and fast
 open

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 28 Apr 2014 22:00:29 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Both TLP and Fast Open call __tcp_retransmit_skb() instead of
> tcp_retransmit_skb() to avoid changing tp->retrans_out.
> 
> This has the side effect of missing SNMP counters increments as well
> as tcp_info tcpi_total_retrans updates.
> 
> Fix this by moving the stats increments of into __tcp_retransmit_skb()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html