netdev - Re: [PATCH V7 net-next 4/7] xen-netback: Correctly clean up after queue initialisation error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140430144954.GA19082@zion.uk.xensource.com>
Date:	Wed, 30 Apr 2014 15:49:54 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	"Andrew J. Bennieston" <andrew.bennieston@...rix.com>
CC:	<xen-devel@...ts.xenproject.org>, <davem@...emloft.net>,
	<ian.campbell@...rix.com>, <wei.liu2@...rix.com>,
	<paul.durrant@...rix.com>, <netdev@...r.kernel.org>,
	<david.vrabel@...rix.com>, <zoltan.kiss@...rix.com>
Subject: Re: [PATCH V7 net-next 4/7] xen-netback: Correctly clean up after
 queue initialisation error.

On Tue, Apr 29, 2014 at 02:27:12PM +0100, Andrew J. Bennieston wrote:
> From: "Andrew J. Bennieston" <andrew.bennieston@...rix.com>
> 
> Multiple queues were introduced in the previous patch, but if the
> initialisation of a queue failed, earlier queues would not be cleaned
> up. This patch adds cleanup logic for this scenario, making use of code
> from the regular teardown sequence.
> 

Shouldn't this patch be folded into that "previous patch" which
introduced this problem? I see you did this for netfront patch already.

Wei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html