netdev - Re: [PATCH V7 net-next 4/7] xen-netback: Correctly clean up after queue initialisation error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <536128CD.3010705@citrix.com>
Date:	Wed, 30 Apr 2014 17:46:05 +0100
From:	Andrew Bennieston <andrew.bennieston@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	<xen-devel@...ts.xenproject.org>, <davem@...emloft.net>,
	<ian.campbell@...rix.com>, <paul.durrant@...rix.com>,
	<netdev@...r.kernel.org>, <david.vrabel@...rix.com>,
	<zoltan.kiss@...rix.com>
Subject: Re: [PATCH V7 net-next 4/7] xen-netback: Correctly clean up after
 queue initialisation error.

On 30/04/14 15:49, Wei Liu wrote:
> On Tue, Apr 29, 2014 at 02:27:12PM +0100, Andrew J. Bennieston wrote:
>> From: "Andrew J. Bennieston" <andrew.bennieston@...rix.com>
>>
>> Multiple queues were introduced in the previous patch, but if the
>> initialisation of a queue failed, earlier queues would not be cleaned
>> up. This patch adds cleanup logic for this scenario, making use of code
>> from the regular teardown sequence.
>>
>
> Shouldn't this patch be folded into that "previous patch" which
> introduced this problem? I see you did this for netfront patch already.
>
> Wei.
>
The netfront patch included this from the beginning; I simply forgot to 
implement it in netback. I added it as a separate patch to make it 
easier to review, but I can certainly merge it in with the other one 
(and indeed should do so to maintain correct behaviour e.g. during a 
bisect).

I think I'd rather receive comments on this separately, then if 
necessary either repost the series with this folded into the relevant 
patch for final merge, or post V8 with it folded after comments have 
been addressed. Especially since this patch series already has some very 
long patches...

Andrew.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html