lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Apr 2014 21:55:13 -0600 From: Jean Sacren <sakiwit@...il.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Cc: e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org, Elizabeth Kappler <elizabeth.m.kappler@...el.com> Subject: [PATCH net] i40e: fix passing wrong error code to i40e_open() The commit 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(), adding i40e_vsi_open()") introduced a new function i40e_vsi_open() with the regression by a typo. Due to the commit, the wrong error code would be passed to i40e_open(). Fix this error in i40e_vsi_open() by turning the macro into a negative value so that i40e_open() could return the pertinent error code correctly. Fixes: 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(), adding i40e_vsi_open()") Signed-off-by: Jean Sacren <sakiwit@...il.com> Cc: Elizabeth Kappler <elizabeth.m.kappler@...el.com> --- 3.14 appears to be affected. Petition for -stable. drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index cf0761f08911..71dfd79f391a 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -4310,7 +4310,7 @@ int i40e_vsi_open(struct i40e_vsi *vsi) goto err_setup_rx; if (!vsi->netdev) { - err = EINVAL; + err = -EINVAL; goto err_setup_rx; } snprintf(int_name, sizeof(int_name) - 1, "%s-%s", -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists