netdev - Re: [PATCH net] i40e: fix passing wrong error code to i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1398925718.2395.14.camel@jtkirshe-mobl>
Date:	Wed, 30 Apr 2014 23:28:38 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jean Sacren <sakiwit@...il.com>
Cc:	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	Elizabeth Kappler <elizabeth.m.kappler@...el.com>
Subject: Re: [PATCH net] i40e: fix passing wrong error code to i40e_open()

On Wed, 2014-04-30 at 21:55 -0600, Jean Sacren wrote:
> The commit 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(),
> adding i40e_vsi_open()") introduced a new function i40e_vsi_open()
> with the regression by a typo. Due to the commit, the wrong error
> code would be passed to i40e_open(). Fix this error in
> i40e_vsi_open() by turning the macro into a negative value so that
> i40e_open() could return the pertinent error code correctly.
> 
> Fixes: 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(), adding
> i40e_vsi_open()")
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> Cc: Elizabeth Kappler <elizabeth.m.kappler@...el.com>
> ---
> 3.14 appears to be affected. Petition for -stable.
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Jean, I have added it to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)