netdev - Re: [PATCH v2 for v3.15] net: mvmdio: Check for a valid interrupt instead of an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140502.161925.32176445889713799.davem@davemloft.net>
Date:	Fri, 02 May 2014 16:19:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ezequiel.garcia@...e-electrons.com
Cc:	netdev@...r.kernel.org, sebastian.hesselbarth@...il.com,
	thomas.petazzoni@...e-electrons.com,
	gregory.clement@...e-electrons.com, tawfik@...vell.com,
	alior@...vell.com
Subject: Re: [PATCH v2 for v3.15] net: mvmdio: Check for a valid interrupt
 instead of an error

From: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Date: Wed, 30 Apr 2014 13:28:51 -0300

> The following commit:
> 
> commit 9ec36cafe43bf835f8f29273597a5b0cbc8267ef
> Author: Rob Herring <robh@...nel.org>
> Date:   Wed Apr 23 17:57:41 2014 -0500
> 
>     of/irq: do irq resolution in platform_get_irq
> 
> changed platform_get_irq() which now returns EINVAL and EPROBE_DEFER,
> in addition to ENXIO. If there's no interrupt for mvmdio, platform_get_irq()
> returns EINVAL, but we currently check only for ENXIO.
> 
> Fix this by looking for a positive integer, which is the proper way of
> validating a virtual interrupt number.
> 
> While at it, add a proper handling for the deferral probe case.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html