netdev - Re: [PATCH] net: ipv4: ip_forward: fix inverted local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140507.152647.350304258692008227.davem@davemloft.net>
Date:	Wed, 07 May 2014 15:26:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv4: ip_forward: fix inverted local_df test

From: Florian Westphal <fw@...len.de>
Date: Sun,  4 May 2014 23:24:31 +0200

> local_df means 'ignore DF bit if set', so if its set we're
> allowed to perform ip fragmentation.
> 
> This wasn't noticed earlier because the output path also drops such skbs
> (and emits needed icmp error) and because netfilter ip defrag did not
> set local_df until couple of days ago.
> 
> Only difference is that DF-packets-larger-than MTU now discarded
> earlier (f.e. we avoid pointless netfilter postrouting trip).
> 
> While at it, drop the repeated test ip_exceeds_mtu, checking it once
> is enough...
> 
> Fixes: fe6cc55f3a9 ("net: ip, ipv6: handle gso skbs in forwarding path")
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied and queued up for -stable, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html