netdev - Re: [PATCH] net: ipv6: send pkttoobig immediately if orig frag size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140507.152829.1489444818446628583.davem@davemloft.net>
Date:	Wed, 07 May 2014 15:28:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: send pkttoobig immediately if orig frag
 size > mtu

From: Florian Westphal <fw@...len.de>
Date: Mon,  5 May 2014 00:03:34 +0200

> If conntrack defragments incoming ipv6 frags it stores largest original
> frag size in ip6cb and sets ->local_df.
> 
> We must thus first test the largest original frag size vs. mtu, and not
> vice versa.
> 
> Without this patch PKTTOOBIG is still generated in ip6_fragment() later
> in the stack, but
> 
> 1) IPSTATS_MIB_INTOOBIGERRORS won't increment
> 2) packet did (needlessly) traverse netfilter postrouting hook.
> 
> Fixes: fe6cc55f3a9 ("net: ip, ipv6: handle gso skbs in forwarding path")
> Signed-off-by: Florian Westphal <fw@...len.de>

Also applied and queued up for -stable, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html