netdev - Re: [PATCH net-next] enic: Add support for adaptive interrupt coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 May 2014 17:00:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com,
	neepatel@...co.com
Subject: Re: [PATCH net-next] enic: Add support for adaptive interrupt
 coalescing

From: Govindarajulu Varadarajan <_govind@....com>
Date: Tue,  6 May 2014 19:54:22 +0530

> From: Sujith Sankar <ssujith@...co.com>
> 
> Signed-off-by: Sujith Sankar <ssujith@...co.com>
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>

Please never submit patches except absolutely the most extremely
trivial ones without a real commit log message explaining what
the change does, how it does it, and why you implemented it that
way.

> +enum hrtimer_restart enic_hrtimer_cb(struct hrtimer *timer)
> +{
> +	return HRTIMER_RESTART;
> +}

For example, I have no idea why in the world you need an hrtimer whose
function is a complete NOP if the networking hardware does the
interrupt coalescing for you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html