netdev - Re: [PATCH 2/3] rtnetlink: fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140507.170416.948105227236114740.davem@davemloft.net>
Date:	Wed, 07 May 2014 17:04:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	popovich_sergei@...l.ru
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] rtnetlink: fix potential NULL pointer dereference

From: Sergey Popovich <popovich_sergei@...l.ru>
Date: Tue,  6 May 2014 18:13:16 +0300

> Now since commit fbdc1e8c6b79 (rtnetlink: walk through all devs in
> netns safely on link params change) group of network devices can

This is not how you do this, first of all that SHA ID doesn't exist
in any tree other than your's.  It's not an existing commit, but
rather one you are adding in this series.

And secondly, and even more importantly, your patch in this series
is adding this new NULL pointer case.

Therefore you should adjust your first patch to handle this properly
since it introduced the possibility of it happening in the first
place.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html