netdev - Re: [PATCH net,stable v2] net: cdc_mbim: __vlan_find_dev_deep need rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140507.151132.1974316124798488454.davem@davemloft.net>
Date:	Wed, 07 May 2014 15:11:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	eric.dumazet@...il.com, gsuarez@...thmicro.com, oliver@...kum.org
Subject: Re: [PATCH net,stable v2] net: cdc_mbim: __vlan_find_dev_deep need
 rcu_read_lock

From: Bjørn Mork <bjorn@...k.no>
Date: Sat,  3 May 2014 16:12:47 +0200

> Fixes this warning introduced by commit 5b8f15f78e6f
> ("net: cdc_mbim: handle IPv6 Neigbor Solicitations"):
> 
> ===============================
> [ INFO: suspicious RCU usage. ]
> 3.15.0-rc3 #213 Tainted: G        W  O
> -------------------------------
> net/8021q/vlan_core.c:69 suspicious rcu_dereference_check() usage!
> 
> other info that might help us debug this:
> 
> rcu_scheduler_active = 1, debug_locks = 1
> no locks held by ksoftirqd/0/3.
 ...
> Fixes: 5b8f15f78e6f ("net: cdc_mbim: handle IPv6 Neigbor Solicitations")
> Signed-off-by: Bjørn Mork <bjorn@...k.no>
> ---
> v2: get a ref to the netdev before releasing the lock.  Thanks to Eric Dumazet
> 
> Please add this to the stable v3.13 and v3.14 queues as well.  Thanks.

Applied, thanks a lot.

If someone feels slightly inspired it might be a good idea to rename
__vlan_find_dev_deep to __vlan_find_dev_deep_rcu.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html