netdev - Re: [PATCH net] Altera TSE: Fix sparse errors and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 May 2014 12:21:24 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Tobias Klauser <tklauser@...tanz.ch>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] Altera TSE: Fix sparse errors and warnings

Hi Tobias,

On Fri, May 9, 2014 at 10:27 AM, Tobias Klauser <tklauser@...tanz.ch> wrote:

>
> This doesn't seem to be related to the sparse/cppcheck cleanup.
> Shouldn't this be an own patch?

Thanks for catching this, I'll break this out in the next version.

>>
>> -struct altera_dmaops altera_dtype_sgdma = {
>> +static struct altera_dmaops altera_dtype_sgdma = {
>
> This can probably also be made const.

I'll look at this and include in the next version submission if possible.

>> -struct altera_dmaops altera_dtype_msgdma = {
>> +static struct altera_dmaops altera_dtype_msgdma = {
>
> Ditto.

Same,

>
> Cheers
> Tobias

Thanks for taking a look at this,

All the best,

Vince
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html