netdev - Re: [PATCH net] Altera TSE: Fix sparse errors and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140509152752.GN6455@distanz.ch>
Date:	Fri, 9 May 2014 17:27:52 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Vince Bridgers <vbridgers2013@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] Altera TSE: Fix sparse errors and warnings

On 2014-05-08 at 20:15:40 +0200, Vince Bridgers <vbridgers2013@...il.com> wrote:
[...]
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index e44a4ae..d1d35f5 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
[...]
> @@ -1362,6 +1376,11 @@ static int altera_tse_probe(struct platform_device *pdev)
>  		of_property_read_bool(pdev->dev.of_node,
>  				      "altr,has-hash-multicast-filter");
>  
> +	/* Set hash filter to not set for now until the
> +	 * multicast filter receive issue is debugged
> +	 */
> +	priv->hash_filter = 0;
> +

This doesn't seem to be related to the sparse/cppcheck cleanup.
Shouldn't this be an own patch?

>  	/* get supplemental address settings for this instance */
>  	priv->added_unicast =
>  		of_property_read_bool(pdev->dev.of_node,
> @@ -1493,7 +1512,7 @@ static int altera_tse_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -struct altera_dmaops altera_dtype_sgdma = {
> +static struct altera_dmaops altera_dtype_sgdma = {

This can probably also be made const.

>  	.altera_dtype = ALTERA_DTYPE_SGDMA,
>  	.dmamask = 32,
>  	.reset_dma = sgdma_reset,
> @@ -1512,7 +1531,7 @@ struct altera_dmaops altera_dtype_sgdma = {
>  	.start_rxdma = sgdma_start_rxdma,
>  };
>  
> -struct altera_dmaops altera_dtype_msgdma = {
> +static struct altera_dmaops altera_dtype_msgdma = {

Ditto.

Cheers
Tobias
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html