netdev - Re: [PATCH net-next] bonding: make a generic sysfs option store and fix comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140509.161326.1808390476882515095.davem@davemloft.net>
Date:	Fri, 09 May 2014 16:13:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nikolay@...hat.com
Cc:	netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
	andy@...yhouse.net
Subject: Re: [PATCH net-next] bonding: make a generic sysfs option store
 and fix comments

From: Nikolay Aleksandrov <nikolay@...hat.com>
Date: Thu,  8 May 2014 14:23:54 +0200

> Introduce a generic option store function for sysfs and remove the
> specific ones. The attribute name is used to match against the option
> which is to be set.
> Also adjust the "name" of tlb_dynamic_lb option to match the sysfs
> entry and fix the comments and comment style in bond_sysfs.c
> The comments which showed obvious behaviour (i.e. behaviour that's seen
> in the option's entry) are removed, the ones that explained important
> points about the setting function have been moved above the respective
> set function in bond_options.c
> 
> There's only 1 exception: num_unsol_na/num_grat_arp since it has 2 names
> 
> CC: Jay Vosburgh <j.vosburgh@...il.com>
> CC: Veaceslav Falico <vfalico@...il.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: David S. Miller <davem@...emloft.net>
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>

Nice cleanup, applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html