netdev - Re: [PATCH 3/5] tcp: use tcp_v4_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 May 2014 15:29:07 -0400
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Yuchung Cheng <ycheng@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, longinus00@...il.com,
	Jerry Chu <hkchu@...gle.com>, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/5] tcp: use tcp_v4_send_synack on first SYN-ACK

On Sun, May 11, 2014 at 11:22 PM, Yuchung Cheng <ycheng@...gle.com> wrote:
> To avoid large code duplication in IPv6, we need to first simplify
> the complicate SYN-ACK sending code in tcp_v4_conn_request().
>
> To use tcp_v4(6)_send_synack() to send all SYN-ACKs, we need to
> initialize the mini socket's receive window before trying to
> create the child socket and/or building the SYN-ACK packet. So we move
> that initialization from tcp_make_synack() to tcp_v4_conn_request()
> as a new function tcp_openreq_init_req_rwin().
>
> After this refactoring the SYN-ACK sending code is simpler and easier
> to implement Fast Open for IPv6.
>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Daniel Lee <longinus00@...il.com>
> Signed-off-by: Jerry Chu <hkchu@...gle.com>
> ---
>  include/net/tcp.h        | 14 +++++-----
>  net/ipv4/tcp_fastopen.c  | 67 ++++++++++++++++++++++--------------------------
>  net/ipv4/tcp_ipv4.c      | 57 ++++++++++++----------------------------
>  net/ipv4/tcp_minisocks.c | 31 ++++++++++++++++++++++
>  net/ipv4/tcp_output.c    | 21 ---------------
>  5 files changed, 85 insertions(+), 105 deletions(-)

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html