netdev - Re: [PATCH 4/5] tcp: improve fastopen icmp handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 May 2014 15:30:58 -0400
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Yuchung Cheng <ycheng@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, longinus00@...il.com,
	Jerry Chu <hkchu@...gle.com>, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 4/5] tcp: improve fastopen icmp handling

On Sun, May 11, 2014 at 11:22 PM, Yuchung Cheng <ycheng@...gle.com> wrote:
> If a fast open socket is already accepted by the user, it should
> be treated like a connected socket to record the ICMP error in
> sk_softerr, so the user can fetch it. Do that in both tcp_v4_err
> and tcp_v6_err.
>
> Also refactor the sequence window check to improve readability
> (e.g., there were two local variables named 'req').
>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Daniel Lee <longinus00@...il.com>
> Signed-off-by: Jerry Chu <hkchu@...gle.com>
> ---
>  net/ipv4/tcp_ipv4.c | 35 ++++++++++++++---------------------
>  net/ipv6/tcp_ipv6.c | 22 +++++++++++++++++-----
>  2 files changed, 31 insertions(+), 26 deletions(-)

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html