netdev - Re: [PATCH net v2] rtnetlink: wait for unregistering devices in rtnl_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140515.153121.1605947735072984728.davem@davemloft.net>
Date:	Thu, 15 May 2014 15:31:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	cwang@...pensource.com, ebiederm@...ssion.com
Subject: Re: [PATCH net v2] rtnetlink: wait for unregistering devices in
 rtnl_link_unregister()

From: David Miller <davem@...emloft.net>
Date: Thu, 15 May 2014 14:50:43 -0400 (EDT)

> From: Cong Wang <xiyou.wangcong@...il.com>
> Date: Thu, 15 May 2014 11:43:26 -0700
> 
>> On Thu, May 15, 2014 at 11:32 AM, David Miller <davem@...emloft.net> wrote:
>>> From: Cong Wang <xiyou.wangcong@...il.com>
>>> Date: Mon, 12 May 2014 15:11:20 -0700
>>>
>>>> +static void rtnl_lock_unregistering_all(void)
>>>
>>> This is just:
>>>
>>>         rtnl_lock_unregistering(&net_namespace_list);
>>>
>>> There is no need to reimplement the entire thing.
>> 
>> This is exactly what I did in v0 (never sent out) locally,
>> I spent few hours to debug the problem. The problem
>> is net_namespace_list links netns by net->list,
>> while rtnl_lock_unregistering() uses net->exit_list.
>> Thus I used an ugly macro in v1.
>> 
>> There seems no other choice than  between
>> an ugly macro and duplicated code.
> 
> Thanks for explaining (again), I'll look at this some more.

Ok, applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html