netdev - Re: [PATCH] net: tunnels - enable module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140515.153721.2222505094570361361.davem@davemloft.net>
Date:	Thu, 15 May 2014 15:37:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	teg@...m.no
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kaber@...sh.net, yoshfuji@...ux-ipv6.org, jmorris@...ei.org,
	kuznet@....inr.ac.ru
Subject: Re: [PATCH] net: tunnels - enable module autoloading

From: Tom Gundersen <teg@...m.no>
Date: Tue, 13 May 2014 10:48:28 +0200

> Enable the module alias hookup to allow tunnel modules to be autoloaded on demand.
> 
> This is in line with how most other netdev kinds work, and will allow userspace
> to create tunnels without having CAP_SYS_MODULE.
> 
> Signed-off-by: Tom Gundersen <teg@...m.no>
> Tested-by: Susant Sahani <susant@...hat.com>

This doesn't even compile:

  CC [M]  net/ipv4/ipip.o
In file included from include/linux/module.h:17:0,
                 from net/ipv4/ipip.c:95:
include/linux/moduleparam.h:21:1: error: expected ‘,’ or ‘;’ before ‘static’
 static const char __UNIQUE_ID(name)[]       \
 ^
include/linux/module.h:86:32: note: in expansion of macro ‘__MODULE_INFO’
 #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                ^
include/linux/module.h:89:30: note: in expansion of macro ‘MODULE_INFO’
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
                              ^
include/linux/netdevice.h:3283:2: note: in expansion of macro ‘MODULE_ALIAS’
  MODULE_ALIAS("netdev-" device)
  ^
net/ipv4/ipip.c:490:1: note: in expansion of macro ‘MODULE_ALIAS_NETDEV’
 MODULE_ALIAS_NETDEV("tunl0");
 ^