netdev - Re: [PATCH] net: pch_gbe depends on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140516.130558.261976058112825591.davem@davemloft.net>
Date:	Fri, 16 May 2014 13:05:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jdelvare@...e.de, netdev@...r.kernel.org, jslaby@...e.cz
Subject: Re: [PATCH] net: pch_gbe depends on x86_32

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 16 May 2014 06:16:01 -0700

> On Fri, 2014-05-16 at 11:29 +0200, Jean Delvare wrote:
>> The pch_gbe driver is for a companion chip to the Intel Atom E600
>> series processors. These are 32-bit x86 processors so the driver is
>> only needed on X86_32.
>> 
>> Signed-off-by: Jean Delvare <jdelvare@...e.de>
>> Cc: Jiri Slaby <jslaby@...e.cz>
>> Cc: David S. Miller <davem@...emloft.net>
>> ---
>>  drivers/net/ethernet/oki-semi/pch_gbe/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> --- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig	2014-03-31 05:40:15.000000000 +0200
>> +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig	2014-05-16 11:20:28.453261606 +0200
>> @@ -4,7 +4,7 @@
>>  
>>  config PCH_GBE
>>  	tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
>> -	depends on PCI && (X86 || COMPILE_TEST)
>> +	depends on PCI && (X86_32 || COMPILE_TEST)
>>  	select MII
>>  	select PTP_1588_CLOCK_PCH
>>  	---help---
>> 
>> 
> 
> Although its always nice to be able to compile it with x86_64 host,
> to make sure we do not add regressions when we change something in a
> core networking part.

That's what COMPILE_TEST is supposed to be for and it's still there :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html