netdev - Re: [bisected] [oops] gre/gro oops in skb_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400260430.7973.222.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 16 May 2014 10:13:50 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Timo Teras <timo.teras@....fi>
Cc:	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [bisected] [oops] gre/gro oops in skb_gro_receive+0x118/0x453

On Fri, 2014-05-16 at 20:01 +0300, Timo Teras wrote:
Documentation/oops-tracing.txtscripts/decodecode
> I believe it crashes, but cannot say with 100% certainty. I can
> test later on if needed. Based on earlier experiment, the only way to
> avoid the crash was to turn off gro on gre1.
> 
> In any case I don't think it should make any effect, since the GRE
> packets arrive IPseced. eth0 is receiving ESP packets - and I believe
> there's no ESP GRO support. Only after decryption they go to gre1, so
> gre1 gro is basically the place where received packets are coalesced.

Oh this is definitely useful.

I thought we might have a problem now with have GRE enabled GRO in
native GRO layer. I was wondering if the double attempt to GRO packets a
second time was a problem.

So it looks like ESP provides packets that are not very gentle for
skb_gro_receive()...

Could you provide scripts/decodecode output ?

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html