netdev - Re: [RFC PATCH] net: Add support for device specific address syncing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140515.230540.466419985495775051.davem@davemloft.net>
Date:	Thu, 15 May 2014 23:05:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...el.com
Cc:	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com,
	jpirko@...hat.com
Subject: Re: [RFC PATCH] net: Add support for device specific address
 syncing

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Wed, 14 May 2014 16:37:27 -0700

> This change provides a function to be used in order to break the
> ndo_set_rx_mode call into a set of address add and remove calls.  The code
> is based on the implementation of dev_uc_sync/dev_mc_sync.  Since they
> essentially do the same thing but with only one dev I simply named my
> functions __dev_uc_sync/__dev_mc_sync.
> 
> I also implemented an unsync version of the functions as well to allow for
> cleanup on close.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> ---
> 
> I still have to do some testing on this patch, but I am looking to see if
> this is the correct approach or if the community would prefer I take a
> different one.

I just wonder about error handling.

The code just seems to stop trying to sync() if one intermediate
sync() fails.

Shouldn't we unwind or signal errors to the caller?

Is the idea that the driver has internal state which will track if
something goes wrong and take care of error recovery itself?  If so,
that kind of indirect error handling doesn't sit too well with me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html