netdev - Re: [PATCH net-next] ip_tunnel: don't add tunnel twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140515.231051.1178432224326720292.davem@davemloft.net>
Date:	Thu, 15 May 2014 23:10:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	duanj.fnst@...fujitsu.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ip_tunnel: don't add tunnel twice

From: Duan Jiong <duanj.fnst@...fujitsu.com>
Date: Thu, 15 May 2014 13:07:02 +0800

> 
> When using command "ip tunnel add" to add a tunnel, the tunnel will be added twice,
> through ip_tunnel_create() and ip_tunnel_update().
> 
> Because the second is unnecessary, so we can just break after adding tunnel
> through ip_tunnel_create().
> 
> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>

ip_tunnel_update() seems to do some things tha ip_tunnel_create()
does not.

For example, setting dev->dev_addr[] and dev->broadcast[] from the
ipv4 parms if appropriate.

I think you need to rethink this change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html