netdev - RE: [PATCH net-next] pktgen: Use seq_puts() where seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1724771A@AcuExch.aculab.com>
Date:	Fri, 16 May 2014 15:08:06 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Alexei Starovoitov' <alexei.starovoitov@...il.com>,
	Thomas Graf <tgraf@...g.ch>
CC:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] pktgen: Use seq_puts() where seq_printf() is
 not needed

From: Alexei Starovoitov
> > -       seq_printf(seq, "dst_mac: ");
> > +       seq_puts(seq, "dst_mac: ");
> 
> tough luck of kernel developers... ;)
> Normal printf() GCC optimizes into puts() automatically.

Yes - a PITA when you are compiling for an embedded system
with a very limited 'libc'.

Unless I was actually worried about the execution time I'd
leave them as seq_printf() for consistency through the function.

	David