[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140516152346.GF8346@casper.infradead.org>
Date: Fri, 16 May 2014 16:23:46 +0100
From: Thomas Graf <tgraf@...g.ch>
To: David Laight <David.Laight@...LAB.COM>
Cc: 'Alexei Starovoitov' <alexei.starovoitov@...il.com>,
"David S. Miller" <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] pktgen: Use seq_puts() where seq_printf() is
not needed
On 05/16/14 at 03:08pm, David Laight wrote:
> From: Alexei Starovoitov
> > > - seq_printf(seq, "dst_mac: ");
> > > + seq_puts(seq, "dst_mac: ");
> >
> > tough luck of kernel developers... ;)
> > Normal printf() GCC optimizes into puts() automatically.
>
> Yes - a PITA when you are compiling for an embedded system
> with a very limited 'libc'.
>
> Unless I was actually worried about the execution time I'd
> leave them as seq_printf() for consistency through the function.
pktgen already used seq_puts() in various places but not
consistently. Now it does. Besides that, checkpatch.pl specifically
complained about the use of seq_printf() on non format strings.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists