netdev - Re: [PATCH 3/4] atm: idt77252: Remove redundant error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140518.211412.1525385415713413915.davem@davemloft.net>
Date:	Sun, 18 May 2014 21:14:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peter.senna@...il.com
Cc:	chas@....nrl.navy.mil, linux-atm-general@...ts.sourceforge.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/4] atm: idt77252: Remove redundant error check

From: Peter Senna Tschudin <peter.senna@...il.com>
Date: Sat, 17 May 2014 20:22:59 +0200

> Remove double checks, and move the call to printk to the
> first check. Also adds KERN_WARNING to printk. The simplified version
> of the coccinelle semantic patch that fixes this issue is as follows:

The appropriate thing to use is pr_warning() rather than add
KERN_WARNING.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html