netdev - Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 18 May 2014 21:14:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	cengelma@....at
Cc:	netdev@...r.kernel.org, amirv@...lanox.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in
 mlx4_en_set_channels()

From: Christian Engelmayer <cengelma@....at>
Date: Sat, 17 May 2014 23:52:03 +0200

> Function mlx4_en_set_channels() stops running ports before performing the
> requested action. In that case local variable 'port_up' is set so that the
> port is restarted at the end of the function, however, in case the port was
> not stopped, variable 'port_up' is left uninitialized and the behaviour is
> undetermined. Detected by Coverity - CID 751497.
> 
> Signed-off-by: Christian Engelmayer <cengelma@....at>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html