lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 19 May 2014 22:19:46 +0200
From:	Thomas Petazzoni <>
To:	Florian Fainelli <>
Subject: Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY

Dear Florian Fainelli,

On Mon, 19 May 2014 12:43:43 -0700, Florian Fainelli wrote:
> +	priv->phydev = of_phy_connect(dev, priv->phy_dn, bcm_sysport_adj_link,
> +					0, priv->phy_interface);
>  	if (!priv->phydev) {
>  		netdev_err(dev, "could not attach to PHY\n");
>  		return -ENODEV;
> @@ -1551,6 +1551,20 @@ static int bcm_sysport_probe(struct platform_device *pdev)
>  	if (priv->phy_interface < 0)
>  		priv->phy_interface = PHY_INTERFACE_MODE_GMII;
> +	/* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is
> +	 * deprecated, we need to register the fixed PHY using the Ethernet
> +	 * MAC node since we do not have a 'fixed-link' subnode.
> +	 */

Actually even if you use the new fixed PHY DT binding, the DT node
linked to the PHY is the Ethernet MAC node. This is because I didn't
want to have a difference between how things are handled between the
old and the new binding.

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists