netdev - Re: [PATCH net-next 3/4] Documentation: devicetree: add old and deprecated 'fixed-link'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140519222248.5694cf62@free-electrons.com>
Date:	Mon, 19 May 2014 22:22:48 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 3/4] Documentation: devicetree: add old and
 deprecated 'fixed-link'

Dear Florian Fainelli,

On Mon, 19 May 2014 12:43:44 -0700, Florian Fainelli wrote:
> Update the fixed-link Device Tree binding documentation to contain
> information about the old and deprecated 5-digit 'fixed-link' property.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  Documentation/devicetree/bindings/net/fixed-link.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/fixed-link.txt b/Documentation/devicetree/bindings/net/fixed-link.txt
> index e956de1be935..a87e28b68dee 100644
> --- a/Documentation/devicetree/bindings/net/fixed-link.txt
> +++ b/Documentation/devicetree/bindings/net/fixed-link.txt
> @@ -18,6 +18,13 @@ properties:
>  * 'asym-pause' (boolean, optional), to indicate that asym_pause should
>    be enabled.
>  
> +Old, deprecated 'fixed-link' binding:
> +
> +* 'fixed-link' : <a b c d e> where a is emulated phy id - choose any,
> +  but unique to the all specified fixed-links, b is duplex - 0 half,
> +  1 full, c is link speed - d#10/d#100/d#1000, d is pause - 0 no
> +  pause, 1 pause, e is asym_pause - 0 no asym_pause, 1 asym_pause.

I know it's copy/pasted from a previous binding document, but I find
the explanation here rather difficult to read, especially the
d#10/d#100/d#1000 thing. Could we have something more readable, like:

 * A 'fixed-link' property in the Ethernet MAC node, with 5 cells, of
   the form <a b c d e>:
   - a: emulated phy id, choose any but unique to all specified
     fixed-links
   - b: duplex configuration: 0 for half duplex, 1 for full duplex
   - c: link speed in Mbit/s, accepted values are: 10, 100 and 1000
   - d: pause configuration: 0 for no pause, 1 for pause
   - e: asym_pause configuration: 0 for no asym_pause, 1 for asym_pause

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html