lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 May 2014 01:22:16 +0400 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org CC: davem@...emloft.net, thomas.petazzoni@...e-electrons.com, devicetree@...r.kernel.org Subject: Re: [PATCH net-next 1/4] net: bcmgenet: use the new fixed PHY helpers Hello. On 05/19/2014 11:43 PM, Florian Fainelli wrote: > of_phy_connect_fixed_link() is becoming obsolete, and also required > platform code to register the fixed PHYs at the specified addresses for > those to be usable. Get rid of it and use the new of_phy_is_fixed_link() > plus of_phy_register_fixed_link() helpers to transition over the new > scheme. > Signed-off-by: Florian Fainelli <f.fainelli@...il.com> > --- > drivers/net/ethernet/broadcom/genet/bcmmii.c | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c > index 4608673beaff..69bc69f86638 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c [...] > @@ -307,15 +308,20 @@ static int bcmgenet_mii_probe(struct net_device *dev) [...] > + phydev = of_phy_connect(dev, priv->phy_dn, bcmgenet_mii_setup, 0, > + priv->phy_interface); The continuation line is indented incorrectly, you should have started it right under 'dev' on the previous line. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists