lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 May 2014 14:52:57 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> Cc: netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org> Subject: Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY helpers 2014-05-19 13:19 GMT-07:00 Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>: > Dear Florian Fainelli, > > On Mon, 19 May 2014 12:43:43 -0700, Florian Fainelli wrote: >> + priv->phydev = of_phy_connect(dev, priv->phy_dn, bcm_sysport_adj_link, >> + 0, priv->phy_interface); >> if (!priv->phydev) { >> netdev_err(dev, "could not attach to PHY\n"); >> return -ENODEV; >> @@ -1551,6 +1551,20 @@ static int bcm_sysport_probe(struct platform_device *pdev) >> if (priv->phy_interface < 0) >> priv->phy_interface = PHY_INTERFACE_MODE_GMII; >> >> + /* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is >> + * deprecated, we need to register the fixed PHY using the Ethernet >> + * MAC node since we do not have a 'fixed-link' subnode. >> + */ > > Actually even if you use the new fixed PHY DT binding, the DT node > linked to the PHY is the Ethernet MAC node. This is because I didn't > want to have a difference between how things are handled between the > old and the new binding. Sure, I agree, and the comment still stands, I am just expressing it that we are not looking for the 'fixed-link' subnode, but the 'fixed-link' 5-digit property here. Would you want me to rephrase that? -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists