netdev - Re: [ath9k-devel] randconfig build error with next-20140519, in drivers/net/wireless/ath/ath9k/dfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGRGNgW2kdG=CUdWpEbpxaVLhVvVg3MzHwkS_M=_Wmaju+q8dw@mail.gmail.com>
Date:	Thu, 22 May 2014 09:31:36 +1000
From:	Julian Calaby <julian.calaby@...il.com>
To:	Rajkumar Manoharan <rmanohar@....qualcomm.com>
Cc:	Jim Davis <jim.epost@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linville <linville@...driver.com>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	ath9k-devel@...ts.ath9k.org, netdev <netdev@...r.kernel.org>
Subject: Re: [ath9k-devel] randconfig build error with next-20140519, in drivers/net/wireless/ath/ath9k/dfs.c

Hi Rajkumar,

On Thu, May 22, 2014 at 12:38 AM, Rajkumar Manoharan
<rmanohar@....qualcomm.com> wrote:
> On Wed, May 21, 2014 at 10:12:26PM +1000, Julian Calaby wrote:
>> Hi Rajkumar,
>>
>> On Wed, May 21, 2014 at 9:01 PM, Rajkumar Manoharan
>> <rmanohar@....qualcomm.com> wrote:
>> > On Mon, May 19, 2014 at 09:31:16AM -0700, Jim Davis wrote:
>> >> Building with the attached random configuration file,
>> >>
>> >> In file included from drivers/net/wireless/ath/ath9k/eeprom.h:22:0,
>> >>                  from drivers/net/wireless/ath/ath9k/hw.h:27,
>> >>                  from drivers/net/wireless/ath/ath9k/dfs.c:18:
>> >> drivers/net/wireless/ath/ath9k/dfs.c: In function ‘ath9k_dfs_process_phyerr’:
>> >> drivers/net/wireless/ath/ath9k/dfs.c:185:14: error: ‘struct ath_softc’
>> >> has no member named ‘debug’
>> >>     pe.ts - sc->debug.stats.dfs_stats.last_ts);
>> >>               ^
>> >> drivers/net/wireless/ath/ath9k/../ath.h:273:41: note: in definition of
>> >> macro ‘ath_dbg’
>> >>    ath_printk(KERN_DEBUG, common, fmt, ##__VA_ARGS__); \
>> >>                                          ^
>> >> drivers/net/wireless/ath/ath9k/dfs.c:186:5: error: ‘struct ath_softc’
>> >> has no member named ‘debug’
>> >>    sc->debug.stats.dfs_stats.last_ts = pe.ts;
>> >>      ^
>> >> make[5]: *** [drivers/net/wireless/ath/ath9k/dfs.o] Error 1
>> >
>> > Please select CONFIG_ATH9K_DEBUGFS.
>>
>> The point of randconfig builds is to ensure that there it's really
>> unlikely that there are any config combinations that don't build, even
>> if they're utterly insane.
>>
>> You should really change the ath9k Kconfig rules or move or add ifdefs
>> to prevent this from being possible.
>>
> Completely agree. But ath9k Kconfig has proper dependecy for
> ATH9K_DFS_DEBUGFS. I am wondering how it is selected w/o ATH9K_DEBUGFS.
>
> config ATH9K_DFS_DEBUGFS
>         def_bool y
>         depends on ATH9K_DEBUGFS && ATH9K_DFS_CERTIFIED
>
> Should it be like this?
>
> config ATH9K_DFS_DEBUGFS
>         def_bool y if (ATH9K_DEBUGFS && ATH9K_DFS_CERTIFIED)

Zefir already posted a patch to fix this particular issue.

Judging by the patch, not all of the debugfs using code was properly
enclosed in #ifdefs.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html