netdev - Re: [PATCH] net: davinci_emac: fix oops caused by uninitialized ndev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7h8upuog5f.fsf@paris.lan>
Date:	Wed, 21 May 2014 16:39:40 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	Sekhar Nori <nsekhar@...com>
Cc:	David Miller <davem@...emloft.net>,
	Linux DaVinci Mailing List 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Linux netdev Mailing List <netdev@...r.kernel.org>,
	Prabhakar Lad <prabhakar.csengg@...il.com>,
	Mugunthan V N <mugunthanvnm@...com>
Subject: Re: [PATCH] net: davinci_emac: fix oops caused by uninitialized ndev->dev

Sekhar Nori <nsekhar@...com> writes:

> Commit e194312854edc22a2faf1931b3c0608fe20cb969 (drivers: net:
> davinci_cpdma: Convert kzalloc() to devm_kzalloc()) triggered
> a bug in emac_probe() wherein dev member of net_device is used
> for devres allocations even before it is initialized.
>
> This patch fixes that by using the struct device in platform_device
> instead.
>
> While at it, use &pdev->dev consistently for console messages instead
> of using ndev->dev for just one case and remove an unnecessary line
> continuation.
>
> Reported-by: Kevin Hilman <khilman@...aro.org>
> Helped-by: George Cherian <george.cherian@...com>
> Signed-off-by: Sekhar Nori <nsekhar@...com>

Tested-by: Kevin Hilman <khilman@...aro.org>

I verified this patch fixes the boot on dm365-evm (legacy boot) and
da850-evm (DT boot).

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html