netdev - Re: [PATCH] net: davinci_emac: fix oops caused by uninitialized ndev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140522.152256.863726183754410883.davem@davemloft.net>
Date:	Thu, 22 May 2014 15:22:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nsekhar@...com
Cc:	khilman@...aro.org, davinci-linux-open-source@...ux.davincidsp.com,
	netdev@...r.kernel.org, prabhakar.csengg@...il.com,
	mugunthanvnm@...com
Subject: Re: [PATCH] net: davinci_emac: fix oops caused by uninitialized
 ndev->dev

From: Sekhar Nori <nsekhar@...com>
Date: Tue, 20 May 2014 15:41:37 +0530

> Commit e194312854edc22a2faf1931b3c0608fe20cb969 (drivers: net:
> davinci_cpdma: Convert kzalloc() to devm_kzalloc()) triggered
> a bug in emac_probe() wherein dev member of net_device is used
> for devres allocations even before it is initialized.
> 
> This patch fixes that by using the struct device in platform_device
> instead.
> 
> While at it, use &pdev->dev consistently for console messages instead
> of using ndev->dev for just one case and remove an unnecessary line
> continuation.
> 
> Reported-by: Kevin Hilman <khilman@...aro.org>
> Helped-by: George Cherian <george.cherian@...com>
> Signed-off-by: Sekhar Nori <nsekhar@...com>
> ---
> This patch fixes a bug in linux-next so it can wait for
> v3.16

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html