netdev - Re: [PATCH net-next] tg3: Override clock, link aware and link idle mode during NVRAM dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 May 2014 00:17:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	prashant@...adcom.com
Cc:	netdev@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH net-next] tg3: Override clock, link aware and link idle
 mode during NVRAM dump

From: Prashant Sreedharan <prashant@...adcom.com>
Date: Fri, 23 May 2014 09:54:44 -0700

> +		if (cpmu_val & (CPMU_CTRL_LINK_AWARE_MODE |
> +				CPMU_CTRL_LINK_IDLE_MODE)) {
> +

Please remove this empty line.

> +			tw32(TG3_CPMU_CTRL, cpmu_val &
> +			     ~(CPMU_CTRL_LINK_AWARE_MODE |
> +			       CPMU_CTRL_LINK_IDLE_MODE));

This is not indented correctly.

The ~() expression is part of the "cpum_val &", it's not
another separate argument to tw32().

Therefore ~() should be indented to the column cpum_val starts
at.

> +		if (need_resched()) {
> +			if (signal_pending(current)) {
> +				eeprom->len += i;
> +				ret = -EINTR;
> +				goto eeprom_done;

Why are you incrementing eeprom->len when you break out of the
loop due to a signal?  You didn't read that extra byte.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html