netdev - Re: [RFC PATCH] Add bridge ifindex to bridge fdb notify msgs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538508D0.5050405@mojatatu.com>
Date:	Tue, 27 May 2014 17:51:12 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Stephen Hemminger <stephen@...workplumber.org>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	wkok@...ulusnetworks.com,
	Shrijeet Mukherjee <shm@...ulusnetworks.com>
Subject: Re: [RFC PATCH] Add bridge ifindex to bridge fdb notify msgs

On 05/27/14 13:05, Roopa Prabhu wrote:

>> I like the idea of this, but the new attribute needs to be part of the
>> set
>> as well as notify and display infrastructure.
>>
> ok thanks, i will resubmit with set and other changes.

I think it is useful for symettry purposes to have both directions
have NDA_MASTER; but other than that, I dont see any purpose NDA_MASTER
serves. A bridge port is specified on the ndm msg to the kernel.
A bridge port can only belong to one master.
The kernel can deduce that already.
Infact i think specifying the NDA_MASTER may cause problems when
the specified NDA_MASTER is not the bridge to which the bridge port
belongs to....

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html