netdev - RE: [PATCH] mwifiex: use time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <477F20668A386D41ADCC57781B1F70430F70F5E285@SC-VEXCH1.marvell.com>
Date:	Tue, 27 May 2014 11:36:26 -0700
From:	Bing Zhao <bzhao@...vell.com>
To:	Manuel Schölling <manuel.schoelling@....de>
CC:	"linville@...driver.com" <linville@...driver.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] mwifiex: use time_after()

Hi Manuel,

Thanks for the patch.

> To be future-proof and for better readability the time comparisons are
> modified to use time_after() instead of plain, error-prone math.
> 
> Signed-off-by: Manuel Schölling <manuel.schoelling@....de>

Acked-by: Bing Zhao <bzhao@...vell.com>

Regards,
Bing

> ---
>  drivers/net/wireless/mwifiex/main.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/main.h b/drivers/net/wireless/mwifiex/main.h
> index d53e1e8..3191066 100644
> --- a/drivers/net/wireless/mwifiex/main.h
> +++ b/drivers/net/wireless/mwifiex/main.h
> @@ -1101,7 +1101,7 @@ mwifiex_11h_get_csa_closed_channel(struct mwifiex_private *priv)
>  		return 0;
> 
>  	/* Clear csa channel, if DFS channel move time has passed */
> -	if (jiffies > priv->csa_expire_time) {
> +	if (time_after(jiffies, priv->csa_expire_time)) {
>  		priv->csa_chan = 0;
>  		priv->csa_expire_time = 0;
>  	}
> --
> 1.7.10.4