netdev - Re: latest net-next: iwlwifi: reproducible SOFTIRQ-unsafe lock order detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5384DB94.9050303@hartkopp.net>
Date:	Tue, 27 May 2014 20:38:12 +0200
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	"Berg, Johannes" <johannes.berg@...el.com>,
	Eric Dumazet <eric.dumazet@...il.com>
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
	"'johannes@...solutions.net'" <johannes@...solutions.net>
Subject: Re: latest net-next: iwlwifi: reproducible SOFTIRQ-unsafe lock order
 detected

Yep! That fixed it.

Tested-by: Oliver Hartkopp <socketcan@...tkopp.net>

Btw. this issue is in net-next.

Regards,
Oliver


On 27.05.2014 20:03, Berg, Johannes wrote:
>> Bug added in commit ea68f46070c7bae608c619ae048f0ad995db74c3
>> ("iwlwifi: pcie: clarify TX queue need_update handling")
>>
>> Please try :
>>
>> diff --git a/drivers/net/wireless/iwlwifi/pcie/tx.c
>> b/drivers/net/wireless/iwlwifi/pcie/tx.c
>> index dde6031f4257..309a13caddcd 100644
>> --- a/drivers/net/wireless/iwlwifi/pcie/tx.c
>> +++ b/drivers/net/wireless/iwlwifi/pcie/tx.c
>> @@ -338,12 +338,12 @@ void iwl_pcie_txq_check_wrptrs(struct iwl_trans
>> *trans)
>>  	for (i = 0; i < trans->cfg->base_params->num_of_queues; i++) {
>>  		struct iwl_txq *txq = &trans_pcie->txq[i];
>>
>> -		spin_lock(&txq->lock);
>> +		spin_lock_bh(&txq->lock);
> 
> Yeah, we have the same commit in the tree:
> 
> commit d090f878b0084344812dc7bb086e98cd24572e58
> Author: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
> Date:   Tue May 13 08:10:51 2014 +0300
> 
>     iwlwifi: pcie: disable BHs in iwl_pcie_txq_check_wrptrs
> 
> I'm not sure why it hasn't hit net.git, I no longer maintain iwlwifi.git.
> 
> johannes
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html