netdev - Re: [PATCH] net: ks8851: Don't use regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140528202327.GK5099@sirena.org.uk>
Date:	Wed, 28 May 2014 21:23:27 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	"David S . Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	Nishanth Menon <nm@...com>
Subject: Re: [PATCH] net: ks8851: Don't use regulator_get_optional()

On Wed, May 28, 2014 at 01:11:12PM -0700, Stephen Boyd wrote:
> We shouldn't be using regulator_get_optional() here. These
> regulators are always present as part of the physical design and
> there isn't any way to use an internal regulator or change the
> source of the reference voltage via software. Given that the only
> users of this driver in the kernel are DT based, this change
> should be transparent to them even if they don't specify any
> supplies because the regulator framework will insert dummy
> supplies as needed.

Reviewed-by: Mark Brown <broonie@...aro.org>

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)