| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5385ACB0.3060206@solarflare.com> Date: Wed, 28 May 2014 10:30:24 +0100 From: Shradha Shah <sshah@...arflare.com> To: <netdev@...r.kernel.org> CC: <linux-net-drivers@...arflare.com> Subject: [PATCH net v2 2/2] sfc: Restrict PIO to 64-bit architectures From: Jon Cooper <jcooper@...arflare.com> Enable PIO for x86_64 architecture only. Not tested on platforms other than x86_64. Fixes:ee45fd92c739db5b7950163d91dfe5f016af6d24 orig-hg-hash: 53dc43553d9bbe1c5a64c49e580ca571ddc470ae Signed-off-by: Shradha Shah <sshah@...arflare.com> --- drivers/net/ethernet/sfc/io.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/sfc/io.h b/drivers/net/ethernet/sfc/io.h index 4d3f119..adadcf0 100644 --- a/drivers/net/ethernet/sfc/io.h +++ b/drivers/net/ethernet/sfc/io.h @@ -66,10 +66,18 @@ #define EFX_USE_QWORD_IO 1 #endif +/* PIO only works on 64-bit architectures */ +#if BITS_PER_LONG == 64 +/* not strictly necessary to restrict to x86 arch, but done for safety + * since unusual write combining behaviour can break PIO. + */ +#ifdef CONFIG_X86_64 /* PIO is a win only if write-combining is possible */ #ifdef ARCH_HAS_IOREMAP_WC #define EFX_USE_PIO 1 #endif +#endif +#endif #ifdef EFX_USE_QWORD_IO static inline void _efx_writeq(struct efx_nic *efx, __le64 value, -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists