netdev - Re: [PATCH net v2 0/2] sfc: Restrict PIO for 64bit arch in order to avoid data corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140530.173820.494414338220972060.davem@davemloft.net>
Date:	Fri, 30 May 2014 17:38:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sshah@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net v2 0/2] sfc: Restrict PIO for 64bit arch in order
 to avoid data corruption

From: Shradha Shah <sshah@...arflare.com>
Date: Wed, 28 May 2014 10:23:01 +0100

> This patch series 
> Fixes: ee45fd92c739db5b7950163d91dfe5f016af6d24
> 
> The linux net driver uses memcpy_toio() in order to copy into
> the PIO buffers.
> Even on a 64bit machine this causes 32bit accesses to a write-
> combined memory region.
> There are hardware limitations that mean that only
> 64bit naturally aligned accesses are safe in all cases. Due to being
> write-combined memory region two 32bit accesses may be coalesced to
> form a 64bit non 64bit aligned access.
> Solution was to open-code the memory copy routines using pointers
> and to only enable PIO for x86_64 machines.
> 
> This bug fix applies to v3.13 and v3.14 stable branches.

You submited this twice and I'm still confused which ones I should
use.

Please resubmit this and address Sergei's feedback, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html