lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 May 2014 11:34:20 +0200 From: Alexander Stein <alexander.stein@...tec-electronic.com> To: Joe Perches <joe@...ches.com> Cc: "David S. Miller" <davem@...emloft.net>, Daniel Krueger <daniel.krueger@...tec-electronic.com>, netdev@...r.kernel.org Subject: Re: [PATCH 1/6] pch_gbe: print invalid MAC address during probe On Monday 26 May 2014 09:24:28, Joe Perches wrote: > On Mon, 2014-05-26 at 15:40 +0200, Alexander Stein wrote: > > show the actual offending MAC address instead of just > > rejecting it > [] > > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c > [] > > @@ -2674,6 +2674,7 @@ static int pch_gbe_probe(struct pci_dev *pdev, > > */ > > dev_err(&pdev->dev, "Invalid MAC address, " > > "interface disabled.\n"); > > + dev_err(&pdev->dev, "%pM\n", adapter->hw.mac.addr); > > Nicer I think on a single line > using just one dev_err > > dev_err(&pdev->dev, "Invalid MAC %pM - interface disabled\n", > adapter->hw.mac.addr); Yep, I'll send a v2 if there is some more feedback on the other patches. Best regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists