netdev - Re: [PATCH] mvme147: use correct order of ram pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mvmvbsqjl87.fsf@hawking.suse.de>
Date:	Wed, 28 May 2014 11:39:20 +0200
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Amos Kong <akong@...hat.com>,
	"Linux\/m68k" <linux-m68k@...r.kernel.org>,
	"netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] mvme147: use correct order of ram pages

Geert Uytterhoeven <geert@...ux-m68k.org> writes:

>> -/* We have 16834 bytes of RAM for the init block and buffers. This places
>> +/* We have 16384 bytes of RAM for the init block and buffers. This places
>>   * an upper limit on the number of buffers we can use. NetBSD uses 8 Rx
>>   * buffers and 2 Tx buffers.
>>   */
>> +#define M147LANCE_RAM_SIZE   16384 /* 16K */
>>  #define LANCE_LOG_TX_BUFFERS 1
>>  #define LANCE_LOG_RX_BUFFERS 3
>
> BTW,I also find it fishy why the driver uses only 1+3 buffers, since more
> RAM is available.

It's 2^1+2^3.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html