netdev - Re: [PATCH net V2 2/2] libphy: Add stubs to hook IEEE MMD Register reads and writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538795C3.8060905@cogentembedded.com>
Date:	Fri, 30 May 2014 00:17:07 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Vince Bridgers <vbridgers2013@...il.com>, f.fainelli@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net V2 2/2] libphy: Add stubs to hook IEEE MMD Register
 reads and writes

Hello.

On 05/29/2014 08:28 PM, Vince Bridgers wrote:

> The Micrel ksz9021 PHY does not support standard IEEE standard MMD
> extended register access, therefore requires stubs to fail the read
> register method and do nothing for the write register method when
> libphy attempts to read and/or configure Energy Efficient Ethernet
> features in PHYS that do support those features. This problem
> was observed on an Altera Cyclone V SOC development kit that
> uses the Synopsys EMAC and the Micrel ksz9021 PHY. This patch
> was tested on the same board, and Energy Efficient Ethernet is
> now disabled as expected since the Micrel PHY does not support that
> feature.

> Signed-off-by: Vince Bridgers <vbridgers2013@...il.com>
> ---
> V2: Split libphy and Micrel specific changes into 2 patches
>      based on review comments
> ---
>   drivers/net/phy/micrel.c |   23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)

> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index d849684..08e9c49 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -316,6 +316,27 @@ static int ksz8873mll_config_aneg(struct phy_device *phydev)
>   	return 0;
>   }
>
> +/* This routine returns -1 as an indication to the caller that the
> + * Micrel ksz9021 10/100/1000 PHY does not support standard IEEE
> + * MMD extended PHY registers.
> + */
> +static int
> +ksz9021_rd_mmd_phyreg(struct phy_device *phydev, int ptrad, int devnum,
> +		      int regnum)
> +{
> +	return -1;
> +}
> +
> +/* This routine does nothing since the Micrel ksz9021 does not support
> + * standard IEEE MMD extended PHY registers.
> + */
> +static void
> +ksz9021_wr_mmd_phyreg(struct phy_device *phydev, int ptrad, int devnum,
> +		      int regnum, u32 val)
> +{
> +	return;

    Not needed.

> +}
> +

WBR, Sergei



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html