netdev - Re: [PATCH net V2 1/2] libphy: Add phy specific function to access mmd phy registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140602.141241.2078113558597319616.davem@davemloft.net>
Date:	Mon, 02 Jun 2014 14:12:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vbridgers2013@...il.com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net V2 1/2] libphy: Add phy specific function to access
 mmd phy registers

From: Vince Bridgers <vbridgers2013@...il.com>
Date: Thu, 29 May 2014 11:28:32 -0500

> -		eee_cap = phy_read_mmd_indirect(phydev->bus, MDIO_PCS_EEE_ABLE,
> -						MDIO_MMD_PCS, phydev->addr);
> +		eee_cap = phydrv->rd_mmd_indirect(phydev, MDIO_PCS_EEE_ABLE,
> +						  MDIO_MMD_PCS, phydev->addr);
> +
 ...
>  		 */
> -		eee_lp = phy_read_mmd_indirect(phydev->bus, MDIO_AN_EEE_LPABLE,
> -					       MDIO_MMD_AN, phydev->addr);
> +		eee_lp = phydrv->rd_mmd_indirect(phydev, MDIO_AN_EEE_LPABLE,
> +						 MDIO_MMD_AN, phydev->addr);
 ...
> -		eee_adv = phy_read_mmd_indirect(phydev->bus, MDIO_AN_EEE_ADV,
> -						MDIO_MMD_AN, phydev->addr);
> +		eee_adv = phydrv->rd_mmd_indirect(phydev, MDIO_AN_EEE_ADV,
> +						  MDIO_MMD_AN, phydev->addr);

In the case above you properly adjusted the argument indentation.

But, in the cases below, you did not.  Please fix this up.

> @@ -1029,14 +1031,14 @@ int phy_init_eee(struct phy_device *phydev, bool clk_stop_enable)
>  			/* Configure the PHY to stop receiving xMII
>  			 * clock while it is signaling LPI.
>  			 */
> -			int val = phy_read_mmd_indirect(phydev->bus, MDIO_CTRL1,
> +			int val = phydrv->rd_mmd_indirect(phydev, MDIO_CTRL1,
>  							MDIO_MMD_PCS,
>  							phydev->addr);
 ...
> @@ -1056,7 +1058,7 @@ EXPORT_SYMBOL(phy_init_eee);
>   */
>  int phy_get_eee_err(struct phy_device *phydev)
>  {
> -	return phy_read_mmd_indirect(phydev->bus, MDIO_PCS_EEE_WK_ERR,
> +	return phydev->drv->rd_mmd_indirect(phydev, MDIO_PCS_EEE_WK_ERR,
>  				     MDIO_MMD_PCS, phydev->addr);
 ...
> +int gen_rd_mmd_indirect(struct phy_device *phydev, int prtad, int devad,
> +			int addr);
> +void gen_wr_mmd_indirect(struct phy_device *phydev, int prtad, int devad,
> +			 int addr, u32 data);

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html