netdev - Re: [PATCH v2 2/2] net: tile: Use helpers from linux/etherdevice.h to check/set MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140530.170656.2098254592489899285.davem@davemloft.net>
Date:	Fri, 30 May 2014 17:06:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tklauser@...tanz.ch
Cc:	cmetcalf@...era.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/2] net: tile: Use helpers from linux/etherdevice.h
 to check/set MAC

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Fri, 30 May 2014 09:47:17 +0200

> Use is_zero_ether_addr() to check for the MAC address being all zeros instead of
> open coding the check.
> 
> Also use ether_addr_copy() instead of a manual memcpy() to set the
> netdev->dev_addr.
> 
> Furthermore, get rid of a redundant assignment of netdev->addr_len. This is
> already set by ether_setup() which is called in tile_net_setup().
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> Acked-by: Chris Metcalf <cmetcalf@...era.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html